Compile error in the example gradle java app

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Compile error in the example gradle java app

mikemil
I am trying to work thru the examples provided on your home page. Thanks for the fix to the other example.

When I run the gradle-java app - below is a snippet of the output:

c:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app>gradle clean run
:clean
:compileJava
C:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app\src\main\java\example\HandlerBootstrap.java:10: error: cannot find symbol
import static org.ratpackframework.guice.Injection.handler;
                                        ^
  symbol:   class Injection
  location: package org.ratpackframework.guice
C:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app\src\main\java\example\HandlerBootstrap.java:10: error: static import only fro
m classes and interfaces
import static org.ratpackframework.guice.Injection.handler;
^
C:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app\src\main\java\example\Main.java:9: error: cannot find symbol
import static org.ratpackframework.guice.Injection.handler;
                                        ^
  symbol:   class Injection
  location: package org.ratpackframework.guice
C:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app\src\main\java\example\Main.java:9: error: static import only from classes and
 interfaces
import static org.ratpackframework.guice.Injection.handler;
^
C:\dev\groovy\ratpack_examples\example-ratpack-gradle-java-app\src\main\java\example\HandlerBootstrap.java:11: error: cannot find symbol
import static org.ratpackframework.handling.Handlers.assetsPath;
^
  symbol:   static assetsPath
  location: class


I don't see an instance of org.ratpackframework.guice.Injection class in the ratpack-guice-0.9.0-SNAPSHOT.jar that is referenced in the HandlerBootstrap source.  There appear to be a couple other compile errors.
Reply | Threaded
Open this post in threaded view
|

Re: Compile error in the example gradle java app

Luke Daley
Administrator
I've pushed fixes. Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: Compile error in the example gradle java app

mikemil
Great, it's working now.

One small suggestion - didn't think it was worth a pull request :

line 55 in HandlerBootstrap  you might want it to be

exchange.getResponse().send("from the nested handler, var1: " + pathTokens.get("var1") + " var2: " + pathTokens.get("var2"));

changed ", " to be "var2: " - otherwise the output doesn't mention var2 and it might look like var1 is a comma-separated list.

Just a suggestion.

Another comment - after testing - the

// Try /static/logo.png  - should be /static/images/logo.png  -just static/logo.png doesn't work, needs /images.
Reply | Threaded
Open this post in threaded view
|

Re: Compile error in the example gradle java app

Luke Daley
Administrator
Change made, thanks :)